Skip to content

PartialOrd + Ord for HeaderSlice, HeaderWithLength and ThinArc #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

PartialOrd + Ord for HeaderSlice, HeaderWithLength and ThinArc #60

merged 2 commits into from
May 22, 2023

Conversation

daddinuz
Copy link
Contributor

No description provided.

@daddinuz
Copy link
Contributor Author

Actually, this is more complicated than I initially thought.

While writing a similar PR here, I realized that PartialOrd/Ord for HeaderSliceWithLength can lead to unclear semantic.

The semantic of PartialOrd/Ord I expect for HeaderSliceWithLength is the same as header-slice tuple (H, T) (totally questionable).

I'll provide an implementation with this semantic, but this could be a breaking change and requires better reasoning before being approved.

Manishearth
Manishearth approved these changes May 22, 2023
View reviewed changes
Copy link
Owner

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is fine

@Manishearth Manishearth merged commit 686a9ea into Manishearth:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daddinuz @Manishearth