Skip to content

remove pyrawfilereader.py#230

Merged
mschwoer merged 1 commit intomainfrom
get_rid_of_thermo_reader
May 12, 2025
Merged

remove pyrawfilereader.py#230
mschwoer merged 1 commit intomainfrom
get_rid_of_thermo_reader

Conversation

@mschwoer
Copy link
Copy Markdown
Contributor

@mschwoer mschwoer commented Feb 18, 2025

Removing the code duplication in raw file reading.
The version in alpharaw is newer, and, as far as I could judge, equivalent to the replaced one

@jalew188 @GeorgWa is this true?

@mschwoer mschwoer requested review from GeorgWa and jalew188 February 19, 2025 09:10
Copy link
Copy Markdown
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, We don't need raw reader in peptdeep anymore

Base automatically changed from lazy_load_pretrained_models to development March 20, 2025 15:00
@mschwoer mschwoer changed the base branch from development to main April 22, 2025 10:17
Copy link
Copy Markdown
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of this. Good catch!

@mschwoer mschwoer marked this pull request as ready for review May 12, 2025 07:30
@mschwoer mschwoer merged commit 019d560 into main May 12, 2025
2 checks passed
@mschwoer mschwoer deleted the get_rid_of_thermo_reader branch May 12, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants