Improve typehinting and docstrings#183
Merged
sophiamaedler merged 2 commits intomainfrom Feb 13, 2025
Merged
Conversation
Collaborator
sophiamaedler
left a comment
sophiamaedler
left a comment
There was a problem hiding this comment.
Thanks for the code format improvements! Much cleaner. I'll try and match this style in the future. Not sure what the best fix for the import statements is. We can get rid of the return types and the import statement but I guess thats not best practice?
if TYPE_CHECKING:
from ashlar.reg import EdgeAligner, Mosaic
Is always removed by ruff linter. Removing the return types and the import statements to ensure that java dependency is only required for the stitching code.
sophiamaedler
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random things that I noticed.