Skip to content

feat: Improve PydanticToHFDatasets.model_to_dict()#239

Merged
rmitsch merged 2 commits intomainfrom
201
Dec 22, 2025
Merged

feat: Improve PydanticToHFDatasets.model_to_dict()#239
rmitsch merged 2 commits intomainfrom
201

Conversation

@rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Dec 22, 2025

Description

Improves PydanticToHFDatasets by

  • adding support for nested model classes
  • eliminating Pydantic deprecation warning
  • refactoring PydanticToHFDatasets for better readability and maintainability

Related Issues

Changes Made

  • Extend and refactor PydanticToHFDatasets

Checklist

  • Tests have been extended to cover changes in functionality
  • Existing and new tests succeed
  • Documentation updated (if applicable)
  • Related issues linked

Screenshots/Examples (if applicable)

@rmitsch rmitsch self-assigned this Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sieves/tasks/utils.py 91.52% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   93.10%   93.21%   +0.10%     
==========================================
  Files          62       62              
  Lines        3541     3554      +13     
==========================================
+ Hits         3297     3313      +16     
+ Misses        244      241       -3     
Files with missing lines Coverage Δ
sieves/tasks/utils.py 93.75% <91.52%> (+4.59%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmitsch rmitsch marked this pull request as ready for review December 22, 2025 20:31
@rmitsch rmitsch merged commit 5c655e2 into main Dec 22, 2025
3 checks passed
@rmitsch rmitsch deleted the 201 branch January 2, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve PydanticToHFDatasets.model_to_dict()

1 participant