fix: handle ConflictError in JobHandler and add corresponding tests#87
Open
fix: handle ConflictError in JobHandler and add corresponding tests#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved handling of conflict scenarios in job and task management, specifically ensuring that tasks are not erroneously rejected or notified when a conflict (such as an already aborted job) occurs. It also adds comprehensive unit tests to verify this behavior.
Error Handling Improvements:
JobHandler(src/job/models/jobHandler.ts) to detectConflictErrorinstances and, in such cases, log a warning and skip both task rejection and job notification, allowing the polling loop to continue without side effects. [1] [2]Testing Enhancements:
jobHandler.spec.tsto assert thatConflictErrordoes not trigger task rejection or job notification, ensuring correct error handling. [1] [2]tileMergeTaskManager.spec.tsto verify that aConflictErrorduring batch publishing (HTTP 409) causes the process to stop immediately and does not continue enqueuing tasks. [1] [2]Related issues: #XXX , #XXX ...
Closes #XXX ...