Merged
Conversation
|
🎫 Related Jira Issue: MAPCO-8806 |
asafMasa
requested changes
Oct 23, 2025
Collaborator
asafMasa
left a comment
asafMasa
left a comment
There was a problem hiding this comment.
😎 Good job, please mind my remarks, thanks!
Assets/com.mapcolonies.core/Services/Analytics/Model/IAnalyticLogParameter.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Model/IAnalyticLogParameter.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Model/UserInputDevices.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Show resolved
Hide resolved
asafMasa
requested changes
Oct 27, 2025
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Show resolved
Hide resolved
Assets/EditorTests/Analytics/UsageAnalyticsManagerReflectionTests.cs
Outdated
Show resolved
Hide resolved
Assets/PlayModeTests/Analytics/UsageAnalyticsIntegrationPlayModeTests.cs
Show resolved
Hide resolved
asafMasa
requested changes
Oct 28, 2025
Assets/EditorTests/Analytics/SerializationTests/LogObjectTests.cs
Outdated
Show resolved
Hide resolved
asafMasa
approved these changes
Oct 29, 2025
asafMasa
added
In Review
geneg
requested changes
Oct 29, 2025
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/UsageAnalyticsManager.cs
Outdated
Show resolved
Hide resolved
Assets/com.mapcolonies.core/Services/Analytics/Managers/AnalyticsManager.cs
Outdated
Show resolved
Hide resolved
asafMasa
added
In Progress
geneg
approved these changes
Oct 30, 2025
asafMasa
requested changes
Oct 30, 2025
baruchInsert-tech
added
Ready for code review
and removed
In Progress
asafMasa
requested changes
Oct 30, 2025
asafMasa
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.