Skip to content

chore: Translation Service (MAPCO-8896)(MAPCO-8895)(MAPCO-8894) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geneg merged 2 commits into from
Dec 7, 2025
Merged

chore: Translation Service (MAPCO-8896)(MAPCO-8895)(MAPCO-8894) #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b1f4f
translation service
geneg Nov 26, 2025
890d8b1
translation service
geneg Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Assets/EditorTests/Localization/TranslationServiceEditorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.IO;
using com.mapcolonies.core.Localization;
using com.mapcolonies.core.Localization.Constants;
using com.mapcolonies.core.Localization.Models;
using Cysharp.Threading.Tasks;
using NUnit.Framework;
using UnityEngine.Localization.Settings;
Expand Down Expand Up @@ -42,7 +43,12 @@ public IEnumerator Missing_File_Does_Not_Throw_And_Unknown_Key_Passthrough()

try
{
await svc.InitializeService(LocalizationConstants.EnglishLocaleIdentifier);
TranslationSettings settings = new TranslationSettings()
{
Locale = LocalizationConstants.EnglishLocaleIdentifier,
LocalFilePath = "Translations/Translations.json"
};
await svc.InitializeService(settings);
LocalizationSettings.SelectedLocale =
LocalizationSettings.AvailableLocales.GetLocale(LocalizationConstants.EnglishLocaleIdentifier);

Expand Down Expand Up @@ -88,7 +94,13 @@ public IEnumerator Runtime_Language_Switch_Reflects_In_Translate()

try
{
await svc.InitializeService(LocalizationConstants.EnglishLocaleIdentifier);
TranslationSettings settings = new TranslationSettings()
{
Locale = LocalizationConstants.EnglishLocaleIdentifier,
LocalFilePath = "Translations/Translations.json"
};

await svc.InitializeService(settings);

LocalizationSettings.SelectedLocale =
LocalizationSettings.AvailableLocales.GetLocale(LocalizationConstants.EnglishLocaleIdentifier);
Expand Down
17 changes: 15 additions & 2 deletions Assets/PlayModeTests/Localization/TranslationServicePlayModeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using UnityEngine.TestTools;
using com.mapcolonies.core.Localization;
using com.mapcolonies.core.Localization.Constants;
using com.mapcolonies.core.Localization.Models;
using Cysharp.Threading.Tasks;

namespace PlayModeTests.Localization
Expand Down Expand Up @@ -42,7 +43,13 @@ public IEnumerator Missing_File_Does_Not_Throw_And_Unknown_Key_Passthrough()

try
{
await svc.InitializeService(LocalizationConstants.EnglishLocaleIdentifier);
TranslationSettings settings = new TranslationSettings()
{
Locale = LocalizationConstants.EnglishLocaleIdentifier,
LocalFilePath = "Translations/Translations.json"
};

await svc.InitializeService(settings);

LocalizationSettings.SelectedLocale =
LocalizationSettings.AvailableLocales.GetLocale(LocalizationConstants.EnglishLocaleIdentifier);
Expand Down Expand Up @@ -89,7 +96,13 @@ public IEnumerator Runtime_Language_Switch_Reflects_In_Translate()

try
{
await svc.InitializeService(LocalizationConstants.EnglishLocaleIdentifier);
TranslationSettings settings = new TranslationSettings()
{
Locale = LocalizationConstants.EnglishLocaleIdentifier,
LocalFilePath = "Translations/Translations.json"
};

await svc.InitializeService(settings);

LocalizationSettings.SelectedLocale =
LocalizationSettings.AvailableLocales.GetLocale(LocalizationConstants.EnglishLocaleIdentifier);
Expand Down
9 changes: 8 additions & 1 deletion Assets/StreamingAssets/DataManagement/app_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,12 @@
"userSettingsFile": "DataManagement/UserSettings/user_settings.json",
"offlineConfigurationFile": "DataManagement/offline_config.json",
"workspacesDirectory": "DataManagement/workspaces",
"remoteConfigurationUrl": "https://example.com/config/getConfig?v=10"
"remoteConfigurationUrl": "https://example.com/config/getConfig?v=10",
"translationSettings": {
"locale": "he-IL",
"localFilePath": "Translations/Translations.json",
"remoteConfigUrl": "",
"showTranslationWarnings": true,
"TargetStringTableName": "Yahalom_HardCoded_Translations"
}
}
145 changes: 72 additions & 73 deletions Assets/StreamingAssets/Translations/Translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,75 +1,74 @@
{
"showTranslationWarnings": true,
"words": [
{
"key": "yahalom.example",
"localizedValues": {
"en": "example",
"he-IL": "דוגמה"
}
},
{
"key": "yahalom.home",
"localizedValues": {
"en": "home",
"he-IL": "בית"
}
},
{
"key": "yahalom.hello",
"localizedValues": {
"en": "hello",
"he-IL": "שלום"
}
},
{
"key": "yahalom.welcome",
"localizedValues": {
"en": "welcome",
"he-IL": "ברוך הבא"
}
},
{
"key": "yahalom.exit",
"localizedValues": {
"en": "exit",
"he-IL": "יציאה"
}
},
{
"key": "yahalom.settings",
"localizedValues": {
"en": "settings",
"he-IL": "הגדרות"
}
},
{
"key": "yahalom.language",
"localizedValues": {
"en": "language",
"he-IL": "שפה"
}
},
{
"key": "yahalom.confirm",
"localizedValues": {
"en": "confirm",
"he-IL": "אישור"
}
},
{
"key": "yahalom.cancel",
"localizedValues": {
"en": "cancel",
"he-IL": "ביטול"
}
},
{
"key": "yahalom.error",
"localizedValues": {
"en": "error",
"he-IL": "שגיאה"
}
}
]
"words": [
{
"key": "yahalom.example",
"localizedValues": {
"en": "example",
"he-IL": "דוגמה"
}
},
{
"key": "yahalom.home",
"localizedValues": {
"en": "home",
"he-IL": "בית"
}
},
{
"key": "yahalom.hello",
"localizedValues": {
"en": "hello",
"he-IL": "שלום"
}
},
{
"key": "yahalom.welcome",
"localizedValues": {
"en": "welcome",
"he-IL": "ברוך הבא"
}
},
{
"key": "yahalom.exit",
"localizedValues": {
"en": "exit",
"he-IL": "יציאה"
}
},
{
"key": "yahalom.settings",
"localizedValues": {
"en": "settings",
"he-IL": "הגדרות"
}
},
{
"key": "yahalom.language",
"localizedValues": {
"en": "language",
"he-IL": "שפה"
}
},
{
"key": "yahalom.confirm",
"localizedValues": {
"en": "confirm",
"he-IL": "אישור"
}
},
{
"key": "yahalom.cancel",
"localizedValues": {
"en": "cancel",
"he-IL": "ביטול"
}
},
{
"key": "yahalom.error",
"localizedValues": {
"en": "error",
"he-IL": "שגיאה"
}
}
]
}
39 changes: 39 additions & 0 deletions Assets/com.mapcolonies.core/Localization/Models/TranslationSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
using System;
using com.mapcolonies.core.Localization.Constants;

namespace com.mapcolonies.core.Localization.Models
{
[Serializable]
public record TranslationSettings
{
public string Locale
{
get;
set;
} = LocalizationConstants.HebrewLocaleIdentifier;

public string LocalFilePath
{
get;
set;
}

public string RemoteConfigUrl
{
get;
set;
}

public bool ShowTranslationWarnings
{
get;
set;
}

public string TargetStringTableName
{
get;
set;
}
}
}
3 changes: 3 additions & 0 deletions Assets/com.mapcolonies.core/Localization/Models/TranslationSettings.cs.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading