-
Notifications
You must be signed in to change notification settings - Fork 9
Fix compass button undefined error #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s button is rendered before accessing its style
📝 WalkthroughWalkthroughAdded a null/undefined guard in mi-my-position's setCompassStyle to avoid accessing the compass button's style before the element exists; updated two changelogs documenting the fix (components v13.32.1, map-template v1.89.6). Changes
Sequence Diagram(s)(Skipped — change is a small defensive check; no new multi-component control flow introduced.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matbmapspeople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you run npm i && npx lerna run build? Just to make sure all is up-to-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/map-template/CHANGELOG.md (1)
8-19: Resolve duplicate version number conflict.There are two separate entries for version
1.89.5with different dates and different changes. This violates semantic versioning principles.If version 1.89.5 was already released on 2025-12-16, the new fix should be versioned as 1.89.6 (or the next appropriate version). If 1.89.5 hasn't been released yet, consolidate these entries into a single version.
🤖 Fix all issues with AI Agents
In @packages/components/CHANGELOG.md:
- Line 8: Update the version date on the changelog header "## [13.32.1] -
2025-01-06" to the correct year by changing it to "## [13.32.1] - 2026-01-06" so
the entry is correctly ordered after the 2025-12-11 entry.
In @packages/map-template/CHANGELOG.md:
- Line 8: Update the release header line "## [1.89.5] - 2025-01-06" to use the
correct year by changing the date to "2026-01-06"; additionally, to avoid a
duplicate version entry, consider bumping the version token in that header to
"1.89.6" (i.e., change "## [1.89.5] - 2025-01-06" to either "## [1.89.5] -
2026-01-06" if the version is correct, or "## [1.89.6] - 2026-01-06" if you need
a new release entry).
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
packages/components/CHANGELOG.mdpackages/components/src/components/my-position/my-position.tsxpackages/map-template/CHANGELOG.md
🔇 Additional comments (1)
packages/components/src/components/my-position/my-position.tsx (1)
406-410: LGTM! Good defensive programming.The null check prevents the TypeError when
compassButtonhasn't been rendered yet. This handles edge cases wheresetCompassStylemight be called before the ref is assigned.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.