Skip to content

Conversation

@matbmapspeople
Copy link
Collaborator

@matbmapspeople matbmapspeople commented Jan 9, 2026

…psindoors/map-template to 1.89.7 in package-lock.json

Summary by CodeRabbit

  • Bug Fixes

    • Upgraded the MapsIndoors Web SDK to version 4.47.0, improving map functionality and stability.
  • Documentation

    • Added a changelog entry reflecting the SDK upgrade.

✏️ Tip: You can customize this high-level summary in your review settings.

…psindoors/map-template to 1.89.7 in package-lock.json
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

📝 Walkthrough

Walkthrough

Updated MapsIndoors Web SDK reference from v4.46.1 to v4.47.0 and added a changelog entry documenting the upgrade; Subresource Integrity hash in the MapTemplate component was updated accordingly.

Changes

Cohort / File(s) Change Summary
Changelog Update
packages/map-template/CHANGELOG.md
Added new entry 1.89.8 dated 2025-01-09 documenting upgrade to Web SDK 4.47.0.
SDK Version Bump
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Updated MapsIndoors Web SDK script source from 4.46.1 to 4.47.0 and replaced the Subresource Integrity (integrity) hash to match the new bundle.

Sequence Diagram(s)

(omitted — change is an SDK version bump without new multi-component control flow)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Lucaci-Andrei

Poem

🐰 A hop to 4.47, the script takes flight,

Hash snug and tidy, everything's bright,
The map wakes up, ready to show,
Paths and places in a gentle glow,
A rabbit cheers for a version right! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating MapTemplate to use MapsIndoors SDK version 4.47.0, which aligns with the actual file modifications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between faeedaf and f5f6a14.

📒 Files selected for processing (1)
  • packages/map-template/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/map-template/CHANGELOG.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
packages/map-template/CHANGELOG.md (1)

8-18: Fix duplicate 1.89.4 changelog entry + incorrect date/version placement.
You now have two ## [1.89.4] sections (Line 8 and Line 32), and the new one is dated 2025-01-09, which doesn’t align with the current release timeline. This should be moved to the correct version (likely 1.89.7) or renamed to the intended new version.

Proposed fix (move the SDK upgrade note under 1.89.7 and remove the duplicate 1.89.4 block)
-## [1.89.4] - 2025-01-09
-
-### Fixed
-
-- Upgraded to Web SDK version 4.47.0.
-
 ## [1.89.7] - 2026-01-07
 
 ### Fixed
 
+- Upgraded to Web SDK version 4.47.0.
 - An issue when floor level was not respected when setting locationId prop.

Also applies to: 32-36

packages/map-template/src/components/MapTemplate/MapTemplate.jsx (1)

228-244: Add onerror handler and optional timeout to prevent indefinite stalling on SDK load failure.

The initializeMapsIndoorsSDK() function currently only resolves on onload, with no handling for load failures. If the script fetch fails (bad URL, network error, or SRI mismatch), the promise never resolves and the application will hang indefinitely.

Consider updating the code to:

miSdkApiTag.onerror = () => {
    reject(new Error('Failed to load MapsIndoors SDK'));
};

// Optionally add a timeout to surface issues faster
const timeout = setTimeout(() => {
    reject(new Error('MapsIndoors SDK load timeout'));
}, 30000);

miSdkApiTag.onload = () => {
    clearTimeout(timeout);
    resolve();
};
miSdkApiTag.onerror = () => {
    clearTimeout(timeout);
    reject(new Error('Failed to load MapsIndoors SDK'));
};

This ensures that load failures are properly surfaced rather than silently stalling the initialization.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e8ed3b and faeedaf.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • packages/map-template/CHANGELOG.md
  • packages/map-template/src/components/MapTemplate/MapTemplate.jsx

@matbmapspeople matbmapspeople merged commit 577c5c4 into main Jan 9, 2026
1 check passed
@matbmapspeople matbmapspeople deleted the feature/upgrade_web_sdk_version branch January 9, 2026 10:52
@coderabbitai coderabbitai bot mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants