-
Notifications
You must be signed in to change notification settings - Fork 9
Update MapTemplate to use MapsIndoors SDK version 4.47.0 and bump @ma… #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…psindoors/map-template to 1.89.7 in package-lock.json
📝 WalkthroughWalkthroughUpdated MapsIndoors Web SDK reference from v4.46.1 to v4.47.0 and added a changelog entry documenting the upgrade; Subresource Integrity hash in the MapTemplate component was updated accordingly. Changes
Sequence Diagram(s)(omitted — change is an SDK version bump without new multi-component control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/map-template/CHANGELOG.md (1)
8-18: Fix duplicate1.89.4changelog entry + incorrect date/version placement.
You now have two## [1.89.4]sections (Line 8 and Line 32), and the new one is dated2025-01-09, which doesn’t align with the current release timeline. This should be moved to the correct version (likely1.89.7) or renamed to the intended new version.Proposed fix (move the SDK upgrade note under 1.89.7 and remove the duplicate 1.89.4 block)
-## [1.89.4] - 2025-01-09 - -### Fixed - -- Upgraded to Web SDK version 4.47.0. - ## [1.89.7] - 2026-01-07 ### Fixed +- Upgraded to Web SDK version 4.47.0. - An issue when floor level was not respected when setting locationId prop.Also applies to: 32-36
packages/map-template/src/components/MapTemplate/MapTemplate.jsx (1)
228-244: Addonerrorhandler and optional timeout to prevent indefinite stalling on SDK load failure.The
initializeMapsIndoorsSDK()function currently only resolves ononload, with no handling for load failures. If the script fetch fails (bad URL, network error, or SRI mismatch), the promise never resolves and the application will hang indefinitely.Consider updating the code to:
miSdkApiTag.onerror = () => { reject(new Error('Failed to load MapsIndoors SDK')); }; // Optionally add a timeout to surface issues faster const timeout = setTimeout(() => { reject(new Error('MapsIndoors SDK load timeout')); }, 30000); miSdkApiTag.onload = () => { clearTimeout(timeout); resolve(); }; miSdkApiTag.onerror = () => { clearTimeout(timeout); reject(new Error('Failed to load MapsIndoors SDK')); };This ensures that load failures are properly surfaced rather than silently stalling the initialization.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
packages/map-template/CHANGELOG.mdpackages/map-template/src/components/MapTemplate/MapTemplate.jsx
…psindoors/map-template to 1.89.7 in package-lock.json
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.