Skip to content

chore: update map-template to version 1.96.18 and add chat window flag #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lucaci-Andrei merged 1 commit into from
Mar 26, 2026
Merged

chore: update map-template to version 1.96.18 and add chat window flag #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/map-template/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.96.19] - 2026-03-26

### Fixed

- Added flag for chat window
Comment on lines +8 to +12
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Changelog entry should be categorized under "Added" instead of "Fixed".

Adding a feature flag for the chat window is new functionality, not a bug fix. Per Keep a Changelog conventions:

  • Added — for new features
  • Fixed — for any bug fixes
📝 Suggested fix 
 ## [1.96.19] - 2026-03-26
 
-### Fixed
+### Added
 
-- Added flag for chat window
+- Added flag for chat window.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [1.96.19] - 2026-03-26
### Fixed
- Added flag for chat window
## [1.96.19] - 2026-03-26
### Added
- Added flag for chat window.
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/map-template/CHANGELOG.md` around lines 8 - 12, Update the changelog
entry for version [1.96.19] so the "Added flag for chat window" bullet is under
the "Added" section instead of "Fixed": create or move the bullet into an "###
Added" heading (remove it from "### Fixed") to reflect new functionality; ensure
the version header "[1.96.19] - 2026-03-26" remains unchanged and that the text
"Added flag for chat window" is preserved under the new "Added" category.


## [1.96.18] - 2026-03-26

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/map-template/src/components/MapTemplate/MapTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ function MapTemplate({ apiKey, gmApiKey, mapboxAccessToken, venue, locationId, p
}, [language, appConfig, currentLanguage, setCurrentLanguage, userSelectedLanguage]);

return (
<GeminiProvider enabled={true}>
<GeminiProvider enabled={appConfig?.appSettings?.enableChat === 'true'}>
<div className={`mapsindoors-map
${currentAppView === appStates.DIRECTIONS ? 'mapsindoors-map--hide-elements' : 'mapsindoors-map--show-elements'}
${(venuesInSolution.length > 1 && showVenueSelector) ? '' : 'mapsindoors-map--hide-venue-selector'}
Expand Down
Loading