Skip to content

Feature/matb/add searchexternalid appconfig #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matbmapspeople merged 4 commits into from
Mar 31, 2026
+11 −3
Merged

Feature/matb/add searchexternalid appconfig #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61f669e
Update MapTemplate to use local script source and enhance searchExter…
matbmapspeople Mar 31, 2026
3e26442
Update MapTemplate to use external SDK script source and add integrit…
matbmapspeople Mar 31, 2026
b420e9f
build
matbmapspeople Mar 31, 2026
b25f407
Update CHANGELOG to document the addition of `searchExternalLocations…
matbmapspeople Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/map-template/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.96.21] - 2026-03-31

### Fixed

- `searchExternalLocations` can be now also set via App Config.

## [1.96.20] - 2026-03-27

### Fixed
Expand Down
6 changes: 4 additions & 2 deletions packages/map-template/src/components/MapTemplate/MapTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,10 @@ function MapTemplate({ apiKey, gmApiKey, mapboxAccessToken, venue, locationId, p
* React on changes to the searchExternalLocations prop.
*/
useEffect(() => {
setSearchExternalLocations(searchExternalLocations);
}, [searchExternalLocations]);
const externalLocationsConfig = appConfig?.appSettings?.searchExternalLocations;
const showExternalLocations = externalLocationsConfig !== undefined ? externalLocationsConfig === 'true' : searchExternalLocations;
setSearchExternalLocations(showExternalLocations);
}, [searchExternalLocations, appConfig]);

/*
* React on changes to the center prop.
Expand Down
Loading