Review and improve panel and panel-material-ui skills#167
Open
philippjfr wants to merge 2 commits intoMarcSkovMadsen:mainfrom
Open
Review and improve panel and panel-material-ui skills#167philippjfr wants to merge 2 commits intoMarcSkovMadsen:mainfrom
philippjfr wants to merge 2 commits intoMarcSkovMadsen:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the documentation “skills” for panel and panel-material-ui, focusing on making the guidance clearer and less verbose while correcting small errors.
Changes:
- Simplified the dependency listings in
skills/panel/SKILL.md. - Updated/expanded guidance in
skills/panel-material-ui/SKILL.mdaround theming/styling and icon usage, and removed incorrect theming synchronization guidance. - Fixed minor typos and wording issues across both skill documents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| skills/panel/SKILL.md | Streamlines dependency descriptions and makes small guidance tweaks (reactivity, performance tip, typos). |
| skills/panel-material-ui/SKILL.md | Adds clearer theming/styling guidance, documents :material/...: usage, removes incorrect theming advice, and fixes small formatting/typo issues. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I started reviewing the
panelandpanel-material-uiskills. For now these are fairly light edits::material/icon:syntaxbut I do have some questions and concerns that could lead to larger edits.
panelskill?@MarcSkovMadsen For you review.