Skip to content

Support for various config file names#2

Merged
MarcinOrlowski merged 3 commits intomasterfrom
multiple-config-files
Nov 7, 2025
Merged

Support for various config file names#2
MarcinOrlowski merged 3 commits intomasterfrom
multiple-config-files

Conversation

@MarcinOrlowski
Copy link
Owner

No description provided.

MarcinOrlowski and others added 3 commits November 6, 2025 02:48
…-devbar.yml) - bump to v1.1.0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@MarcinOrlowski MarcinOrlowski self-assigned this Nov 7, 2025
@MarcinOrlowski MarcinOrlowski merged commit c98d805 into master Nov 7, 2025
10 checks passed
@MarcinOrlowski MarcinOrlowski deleted the multiple-config-files branch November 7, 2025 07:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for multiple configuration filenames, allowing users to choose between .disco-devbar.yaml, .disco-devbar.yml, or the legacy .debug-banner.yaml format. The version has been bumped from 1.0.0 to 1.1.0.

  • Refactored configuration file loading to support multiple filenames with preference order
  • Added new recommended configuration filenames (.disco-devbar.yaml, .disco-devbar.yml)
  • Maintained backward compatibility with the legacy .debug-banner.yaml filename

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/Service/DiscoDevBarService.php Replaced single config filename with array of supported filenames, added findConfigFile() method to iterate through options and return first existing file
composer.json Updated version from 1.0.0 to 1.1.0
README.md Updated documentation to list new configuration filenames and their preference order
CHANGES.md Added changelog entry for v1.1.0 documenting the new config filename support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- Added support for multiple config filenames: `.disco-devbar.yaml`, `.disco-devbar.yml`

## v1.0.0 (2025-qq-05)
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date format used here ("2025-qq-05") appears to be a placeholder that was never replaced with the actual date. This should be corrected to include the proper month abbreviation or numeric representation.

Suggested change
## v1.0.0 (2025-qq-05)
## v1.0.0 (2025-10-05)

Copilot uses AI. Check for mistakes.
detect and load the first file found (in order of preference):

- `.disco-devbar.yaml` (recommended)
- `.disco-devbar.yml`
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation doesn't mention that .debug-banner.yaml is still supported for backward compatibility. Users who have existing configurations using this filename should be informed that it will continue to work, or that they should migrate to the new naming convention.

Suggested change
- `.disco-devbar.yml`
- `.disco-devbar.yml`
- `.debug-banner.yaml` (supported for backward compatibility; consider migrating to `.disco-devbar.yaml`)

Copilot uses AI. Check for mistakes.

## v1.1.0 (2025-11-07)

- Added support for multiple config filenames: `.disco-devbar.yaml`, `.disco-devbar.yml`
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog doesn't mention that .debug-banner.yaml is still supported for backward compatibility. This is an important detail for existing users who may have this file already configured.

Suggested change
- Added support for multiple config filenames: `.disco-devbar.yaml`, `.disco-devbar.yml`
- Added support for multiple config filenames: `.disco-devbar.yaml`, `.disco-devbar.yml`
- `.debug-banner.yaml` is still supported for backward compatibility.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants