Skip to content

MDEV-38126 Dead code, race conditions and contentious lock_operations in audit plugin #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+348 −1,337
Open

MDEV-38126 Dead code, race conditions and contentious lock_operations in audit plugin #4449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06da823
MDEV-38126: Remove dead code for MySQL 5.7 and old MariaDB
dr-m Nov 19, 2025
cadc958
MDEV-38126: Convert plugin/server_audit to C++11
dr-m Nov 19, 2025
1c8b9a0
MDEV-38126: Remove __attribute__((unused)) from plugin/server_audit
dr-m Nov 19, 2025
f66cfd9
MDEV-38126: Remove lock_atomic from plugin/server_audit
dr-m Nov 19, 2025
f102d1b
MDEV-38126: Use InnoDB srw_lock_low for plugin/server_audit
dr-m Nov 19, 2025
5676ecf
MDEV-38126: Fix -DWITH_UBSAN=ON
dr-m Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mysys/file_logger.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ int logger_set_rotations(LOGGER_HANDLE *log, unsigned int new_rotations)
return 0;
}

void logger_init_mutexes()
void logger_init_mutexes(void)
{
#ifdef HAVE_PSI_INTERFACE
if (unlikely(PSI_server))
Expand Down
3 changes: 2 additions & 1 deletion mysys/mf_iocache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,8 @@ int my_b_flush_io_cache(IO_CACHE *info, int need_append_buffer_lock)

if ((length=(size_t) (info->write_pos - info->write_buffer)))
{
my_off_t eof= info->end_of_file + info->write_pos - info->append_read_pos;
my_off_t eof= info->end_of_file +
(ptrdiff_t)(info->write_pos - info->append_read_pos);
if (append_cache)
{
if (tmp_file_track(info, eof) ||
Expand Down
2 changes: 1 addition & 1 deletion plugin/server_audit/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA

SET(SOURCES server_audit.c test_audit_v4.c plugin_audit_v4.h)
SET(SOURCES server_audit.cc)

MYSQL_ADD_PLUGIN(server_audit ${SOURCES} MODULE_ONLY RECOMPILE_FOR_EMBEDDED)
Loading