Anticor Bug fix for undefined correlation#111
Open
Aguspanale wants to merge 1 commit intoMarigold:masterfrom
Open
Anticor Bug fix for undefined correlation#111Aguspanale wants to merge 1 commit intoMarigold:masterfrom
Aguspanale wants to merge 1 commit intoMarigold:masterfrom
Conversation
Stumbled upon NAN values while using the ANTICOR implementation, the original paper states that : (page 6) We note that if sigma1(i) (respectively, sigma2(j)) is zero over some window then the growth rate of stock i during the second last window (respectively, stock j during the last window) is constant during this window. For sufficiently large windows of time constant growth of any stock i is unlikely. However, in this unlikely case we choose not to move money into or out of such a stock i.12. To make the implementation take this detail into account, i simply skipped transfers that could have NAN values from an undefined correlation.
Aguspanale
changed the title
Marigold
approved these changes
Aug 2, 2024
Owner
Marigold
left a comment
Marigold
left a comment
There was a problem hiding this comment.
Makes sense, thanks a lot for contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled upon NAN values while using the ANTICOR implementation, the original paper states that :
(page 6)
We note that if sigma1(i) (respectively,
sigma2(j)) is zero over some window then the growth rate of stock i during the second last window (respectively, stock j during the last window) is constant during this window. For sufficiently large windows of time constant growth of any stock i is unlikely. However, in this unlikely case we choose not to move money into or out of such a stock i.12.
To make the implementation take this detail into account, i simply skipped transfers that could have NAN values from an undefined correlation.