-
-
Notifications
You must be signed in to change notification settings - Fork 402
Update to .NET 10.0.0 #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 10.0.0 #4763
Conversation
|
MAUI build has some errors, still working on those |
Use .Net 10 release sdk version as minimum sdk version
|
I have a question about #4737 . |
@Bowman74 the issue is that the viewmodel type uses a resource string from Csla.dll - but in the release build that resource is optimized away because it isn't actually used in Csla.dll. I don't know if we should have another resource file just for Csla.Maui? Or figure out how to suppress the optimization by the compiler. |
Hmm. I thought the |
The old behavior was Just to be clear: I find this feature good. |
Can't you just force a reference to that with |
|
@rockfordlhotka There are ways to suppress for some resources. Let me give you a call so I can understand the issue. |
@rockfordlhotka , |
Here's the branch: https://github.com/MarimerLLC/csla/tree/dev/4347-net10 In the CLI do |
Somewhere in the Csla project source code where that won't get optimized away? |
|
@rockfordlhotka, Also, yes that solution would probably be linked away because nothing is using it anywhere. |
Able to reproduce. Let you know when I have something. |
OK, have to run to dinner. I was able to look at the platform specific Csla assemblies in the object browser. Csla.Properties.Resources.UnsupportedXamlListTypeForModel is in there, it wasn't linked away. So the issue likely is with the linker in the Csla.Xaml compile. I'll let you know when I have it sorted after dinner. |
|
@rockfordlhotka
The proper process for the new separated MAUI solution for a new major release is:
For a test on my machine I changed the reference for csla on release builds to be csla version 10.0.0-beta-0010-g983ce0980c. This is the latest version in nuget.org. I then did dotnet pack csla.maui.build.sln and it ran correctly. So the only "change" you will need to make is to manually edit the csla.xaml.maui.csproj to reference the proper nuget.org csla package. Edit to add: https://www.nuget.org/packages/Csla.Maui/10.0.0-beta-0010-g983ce0980c#dependencies-body-tab Second edit too add: |
…ed versions and to update nuget.org Csla package reference to latest beta.
|
@rockfordlhotka I did end up checking in an updated project file that updated the MAUI references to latest release versions (housekeeping) and also update the Csla nuget.org reference to the latest Csla 10 beta. Note, I could not use wildcards (i.e. 10.0.*) for the reference as they don't seem to work for beta versions. That is to say, you will need to update the project file to use the wildcard when the first non beta Csla 10 is deployed. Let me know if you have any questions. |

#4347