Skip to content

Merge devnet 3 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Merge devnet 3 #35

wants to merge 17 commits into from

Conversation

@MariusVanDerWijden
Copy link
Owner

@MariusVanDerWijden MariusVanDerWijden commented Dec 15, 2021

No description provided.

MariusVanDerWijden and others added 17 commits December 7, 2021 12:02
@marioevz
Copy link

marioevz commented Dec 15, 2021

Found a couple of small issues when running tests against this branch:

  • After a executePayload, if a forkchoiceUpdated is sent using the valid payload's hash as HeadBlockHash, but a random hash is used as SafeBlockHash, the call is successful even though it's not possible that SafeBlockHash is HeadBlockHash's ancestor.
  • Sending a forkchoiceUpdated with a random HeadBlockHash, and known SafeBlockHash/FinalizedBlockHash, results in "Server error" (Test expects no error and Status=="SYNCING")

MariusVanDerWijden pushed a commit that referenced this pull request Jan 23, 2023
@roberto-bayardo
Make tx/message data get accessed consistently through st.msg (#35)
91322eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MariusVanDerWijden @marioevz @karalabe