fix(upload): 🐛 prevent action bar overlap on long file lists#53
Merged
fix(upload): 🐛 prevent action bar overlap on long file lists#53
Conversation
There was a problem hiding this comment.
Summary
This PR scopes a CSS rule to the Home upload panel and constrains the upload list height so action controls remain visible with long file lists. The change is small, targeted, and aligns with the stated intent of avoiding side effects in other views. I don’t see blocking issues; it looks ready to merge.
Praise
src/renderer/components/UploadPanel.tsx:489— Scoped wrapper for localized styling: Wrapping the panel inhome-upload-panelis a clean way to avoid globally affecting Ant upload lists elsewhere.src/renderer/App.css:50— Practical overflow control: Applyingmax-height+overflow-y: autoon.ant-upload-listdirectly addresses the overlap issue while preserving access to all files via scrolling.src/renderer/App.css:53— Scrollbar stability improvement: Usingscrollbar-gutter: stablehelps reduce layout shift when the scrollbar appears, improving UI consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
🤖 Generated with Codex Cli