Skip to content

fix(upload): 🐛 prevent action bar overlap on long file lists#53

Merged
jorben merged 1 commit intomasterfrom
fix/home-upload-list-scroll
Mar 2, 2026
Merged

fix(upload): 🐛 prevent action bar overlap on long file lists#53
jorben merged 1 commit intomasterfrom
fix/home-upload-list-scroll

Conversation

@jorben
Copy link
Collaborator

@jorben jorben commented Mar 2, 2026

Summary

  • Limit the Home upload file list height to keep bottom action controls visible
  • Add scoped styling for the Home upload panel so the list scrolls within a fixed max height
  • Avoid affecting upload list behavior in other views

Test Plan

  • Run renderer tests for UploadPanel
  • Run repository test suite via pre-commit hook

🤖 Generated with Codex Cli

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR scopes a CSS rule to the Home upload panel and constrains the upload list height so action controls remain visible with long file lists. The change is small, targeted, and aligns with the stated intent of avoiding side effects in other views. I don’t see blocking issues; it looks ready to merge.

Praise

  • src/renderer/components/UploadPanel.tsx:489Scoped wrapper for localized styling: Wrapping the panel in home-upload-panel is a clean way to avoid globally affecting Ant upload lists elsewhere.
  • src/renderer/App.css:50Practical overflow control: Applying max-height + overflow-y: auto on .ant-upload-list directly addresses the overlap issue while preserving access to all files via scrolling.
  • src/renderer/App.css:53Scrollbar stability improvement: Using scrollbar-gutter: stable helps reduce layout shift when the scrollbar appears, improving UI consistency.

@jorben jorben merged commit f3389c2 into master Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant