Skip to content

Conversation

@fhennig42
Copy link
Contributor

With PR #141 I added a replacement stategy for replacing the Unicode characters to handle the different positions in the host environment.
In our recent test we found out, that the regex that is used to deal with the issue is too eager. It also replaces common German Umlaut characters such as "Ä". Therefore I removed the "Stage 4" to be able to use them.

@leeuwe
Copy link
Member

leeuwe commented Dec 9, 2025

@samuelpcabral Thoughts?

@samuelpcabral
Copy link
Member

I will try to check this week...

@samuelpcabral samuelpcabral self-requested a review December 12, 2025 15:42
@samuelpcabral
Copy link
Member

The github actions failed because the changes on read screen, so I can´t approve the PR.

I was checking this today, and this unicodes reads are not so good... but to minimize the impact and as the keyword "Read" is working with german umlauts, the only issue is the series of "full_text.replace" inside read_all_screen.

My suggestion is put one argument in the "@Keyword("Read All Screen")" something like replace_unicode=True to maintain current behavior and if we pass as false.. we skill all replaces... I did this test and worked.

the robot code will be something like this:

Test case
    Open Connection    ${HOST}
    Sleep    4
    Write Bare    ÄÖÜßßä
    Sleep    1
    ${all}    Read All Screen    replace_unicode=${False}
    Log    ${all}    warn
    Close Connection

@fhennig42 What do you think? If you agree I can do the change, is already done in my machine.

@fhennig42
Copy link
Contributor Author

@samuelpcabral yes I agree, please upload the changes

@samuelpcabral
Copy link
Member

WIll be resolved in #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants