Skip to content

Comments

Fixed json-logic queries and added dataview queries#53

Open
jldiaz wants to merge 3 commits intoMarkusPfundstein:mainfrom
jldiaz:main
Open

Fixed json-logic queries and added dataview queries#53
jldiaz wants to merge 3 commits intoMarkusPfundstein:mainfrom
jldiaz:main

Conversation

@jldiaz
Copy link

@jldiaz jldiaz commented Jun 5, 2025

  • The json-logic part was broken because the query was a string, and it should be a python object (to be later serialized as json). The fix checks if query is a string, and tries to parse it as json.
  • Added a new tool DataviewQueryToolHandler which can use the capability of Obsidian API of accepting dataview queries.

- The json-logic part was broken because the query was a string, and it should
  be a python object (to be later serialized as json). The fix checks if query is a
  string, and tries to parse it as json.
- Added a new tool `DataviewQueryToolHandler` which can use the capability
  of Obsidian API of accepting dataview queries.
@AndreasMurk
Copy link

Are there any updates on this? I'm also willing to help if necessary :)

@rkm3
Copy link

rkm3 commented Aug 9, 2025

I'd love to use this too.

ernestkoe added a commit to ernestkoe/mcp-obsidian-ek that referenced this pull request Dec 29, 2025
- Add Windows UTF-8 STDIO encoding fix (PR MarkusPfundstein#75)
- Add ensure_ascii=False to json.dumps for proper Unicode (PR MarkusPfundstein#74)
- Add Dataview query tool for arbitrary DQL queries (PR MarkusPfundstein#53)

Skipped (already fixed by PR MarkusPfundstein#77):
- PR MarkusPfundstein#87: dirpath trailing slashes
- PR MarkusPfundstein#67: list_files_in_dir slash

Skipped (not needed):
- PR MarkusPfundstein#89: env var defaults (our approach works)
- PR MarkusPfundstein#69: too large, needs review

70 tests passing, 26 tools total.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ernestkoe
Copy link

Applied to my maintained fork at https://github.com/ernestkoe/mcp-obsidian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants