Fix: tool list_files_in_dir throws error when the dirpath passed in endswith slash#67
Open
BHznJNs wants to merge 2 commits intoMarkusPfundstein:mainfrom
Open
Fix: tool list_files_in_dir throws error when the dirpath passed in endswith slash#67BHznJNs wants to merge 2 commits intoMarkusPfundstein:mainfrom
list_files_in_dir throws error when the dirpath passed in endswith slash#67BHznJNs wants to merge 2 commits intoMarkusPfundstein:mainfrom
Conversation
…sed in endswith slash
herrbenesch
approved these changes
Jul 23, 2025
ernestkoe
added a commit
to ernestkoe/mcp-obsidian-ek
that referenced
this pull request
Dec 29, 2025
- Add Windows UTF-8 STDIO encoding fix (PR MarkusPfundstein#75) - Add ensure_ascii=False to json.dumps for proper Unicode (PR MarkusPfundstein#74) - Add Dataview query tool for arbitrary DQL queries (PR MarkusPfundstein#53) Skipped (already fixed by PR MarkusPfundstein#77): - PR MarkusPfundstein#87: dirpath trailing slashes - PR MarkusPfundstein#67: list_files_in_dir slash Skipped (not needed): - PR MarkusPfundstein#89: env var defaults (our approach works) - PR MarkusPfundstein#69: too large, needs review 70 tests passing, 26 tools total. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the tool
list_files_in_dirimplementation, when the dirpath passed in is ends with slash, it will build the final obsidian path with the extra slash, which will cause error.