-
Notifications
You must be signed in to change notification settings - Fork 874
Modify author and brief in M494.md #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| --- | ||
| tag: m0494 | ||
| title: FT Motion Trajectory Smoothing | ||
| brief: Set / get the Fixed Time Motion parameters for Trajectory and Smoothing. | ||
| author: thinkyhead | ||
| brief: Set / get the Fixed Time Motion parameters for Trajectory generation and Smoothing. | ||
| author: dbuezas | ||
| contrig: thinkyhead | ||
|
|
||
| group: motion | ||
| requires: FT_MOTION | ||
|
|
@@ -104,8 +105,8 @@ Particularly useful for the E axis when using linear advance, since it produces | |
|
|
||
| Effects on XYZ: | ||
| * no smoothing: sharp corners, but noises and ringing | ||
| * smoothing: rounded corners, no noises and ringing | ||
| * smoothing if overdone: rounded corners, infill may not reach all corners, no noises and ringing | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably needs three bullet points here, because a little bit of smoothing probably rounds corners, even if it is hard to see. Maybe something like this… Smoothing Effects on XYZ
|
||
|
|
||
| Effects on E: | ||
| * no smoothing: extruder skips when using linear advance | ||
| * smoothing: peaks produced by linear advance are reduced, the extruder doesn't skip and quality improves. | ||
| * smoothing: peaks produced by linear advance are reduced, the extruder doesn't skip and quality improves. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.