Skip to content

Fixed support for Electron 30/33 types #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Catlike14 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed support for Electron 30/33 types #258

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cd8920
Fixed support for Electron 30/33 types
Catlike14 Aug 1, 2025
f820f3a
Fixed TS
Catlike14 Aug 1, 2025
e1866e5
Fixed syntax error
Catlike14 Aug 1, 2025
84a0f58
Fixed TS
Catlike14 Aug 1, 2025
3a85217
Update index.ts
Catlike14 Aug 1, 2025
d81f44b
prettier
Catlike14 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export interface InstallExtensionOptions {
session?: Session;
}

type ExtensionApi = Pick<
Session,
'getAllExtensions' | 'removeListener' | 'removeExtension' | 'loadExtension'
> & {
on: Extract<Session['on'], (event: 'extension-unloaded', ...args: any) => any>;
};

/**
* @param extensionReference Extension or extensions to install
* @param options Installation options
Expand Down Expand Up @@ -73,8 +80,10 @@ export async function installExtension(
throw new Error(`Invalid extensionReference passed in: "${extensionReference}"`);
}

const extensionApi: Electron.Extensions | Electron.Session =
(targetSession.extensions as Electron.Extensions | undefined) || targetSession;
const extensionApi: ExtensionApi =
'extensions' in targetSession
? (targetSession as unknown as { extensions: ExtensionApi }).extensions
: targetSession;
const installedExtension = extensionApi.getAllExtensions().find((e) => e.id === chromeStoreID);

if (!forceDownload && installedExtension) {
Expand Down