Use lowercase for UUIDs as defined by the schema file#20
Open
miguelgarcia wants to merge 1 commit intoMassRobotics-AMR:mainfrom
Open
Use lowercase for UUIDs as defined by the schema file#20miguelgarcia wants to merge 1 commit intoMassRobotics-AMR:mainfrom
miguelgarcia wants to merge 1 commit intoMassRobotics-AMR:mainfrom
Conversation
|
Updating the schema to accept uppercase letters might be a more appropriate approach. |
Contributor
Author
|
I have no strong opinion, but I think that at least #20 or #21 should be merged, now the example sender isn't compliant with the schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I had a conflict when trying the example client against the current schema. The issue was that the schema requires lowercase uuids. I fixed the client in this PR.