Use @peculiar/x509 for certificate chain validation #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c73abba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors @simplewebauthn/server to use the @peculiar/x509 library for X.509 certificate chain validation. The X.509 validation logic I'd written could not verify an attestation response when a P-384 ECDSA public key appeared in
x5cin an"android-key"response from Android 10, and I couldn't immediately identify why. I decided this was a good time to re-evaluate why this project needed its own X.509 validation logic when more battle-tested libraries exist to handle edge cases I hadn't accounted for.Fixes #705.