Skip to content

Fix abnormally large registration user IDs from Node Buffers #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MasterKale merged 2 commits into from
Sep 17, 2025
Merged

Fix abnormally large registration user IDs from Node Buffers #724

MasterKale merged 2 commits into from
Sep 17, 2025

Conversation

@MasterKale
Copy link
Owner

@MasterKale MasterKale commented Sep 17, 2025

This PR fixes the issue of user.id in the output from generateRegistrationOptions() being many thousands of characters long, most of them As:

image image

Now, the userID argument will be correctly encoded to a more sensible base64url string:

Screenshot 2025-09-16 at 11 33 04 PM

Fixes #723.

@MasterKale MasterKale added the package:server @simplewebauthn/server label Sep 17, 2025
@MasterKale MasterKale added this to the v13.2.1 milestone Sep 17, 2025
@MasterKale MasterKale merged commit e8a8062 into master Sep 17, 2025
4 checks passed
@MasterKale MasterKale deleted the fix/723-large-user-id-node-buffer branch September 17, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package:server @simplewebauthn/server

Projects

None yet

Milestone

v13.2.1

Development

Successfully merging this pull request may close these issues.

"generateRegistrationOptions" in "@simplewebauthn/server" generates a strange user-id

2 participants

@MasterKale