Add LUKS recovery key to vault #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkumarmk
force-pushed
the
t1
branch
2 times, most recently
from
1448093 to
1ccdc7a
Compare
hkumarmk
force-pushed
the
t1
branch
22 times, most recently
from
105cc96 to
adfde15
Compare
sorenisanerd
reviewed
Dec 5, 2025
Collaborator
|
Sorry about the wait. My dev branch was waaay out of date with main, and my local working tree had a lot of changes, too. It's all pretty well aligned now and the tests should be passing. If you can rebase on top of main now, we should be in good shape 🤞🏻 |
hkumarmk
force-pushed
the
t1
branch
2 times, most recently
from
d52020e to
9b79967
Compare
Collaborator
Author
|
@sorenisanerd can you pls review this? |
sorenisanerd
requested changes
Jan 7, 2026
hkumarmk
force-pushed
the
t1
branch
10 times, most recently
from
8ffdea8 to
3b39e7e
Compare
* Add LUKS recovery key to vault as part of mangoctl bootstrap or enroll for LUKS volumes in each node * added validation steps in self_test.sh * Added additional recovery_test.sh to run as part of integration test within run_tests.sh * add machine id entity metadata for a node in the vault * Add policy so node token can write (not update or read) recovery key in vault kv
hkumarmk
force-pushed
the
t1
branch
10 times, most recently
from
154463b to
2901862
Compare
sorenisanerd
approved these changes
Jan 13, 2026
Collaborator
sorenisanerd
left a comment
sorenisanerd
left a comment
There was a problem hiding this comment.
lgtm!
Congrats on your first PR getting merged :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LUKS recovery key to vault
* Add LUKS recovery key to vault as part of mangoctl bootstrap or enroll
for LUKS volumes in each node
* added validation steps in self_test.sh
* Added additional recovery_test.sh to run as part of integration test
within run_tests.sh