Rename TabScrollOffset

Author: nicolaihenriksen

src/MaterialDesignThemes.Wpf/Behaviors/Internal/TabControlHeaderScrollBehavior.cs

@@ -1,4 +1,4 @@
-using System.Diagnostics;
+using System.Diagnostics;
 using System.Windows.Media.Animation;
 using Microsoft.Xaml.Behaviors;
 
@@ -70,7 +70,7 @@ private static void OnScrollableContentChanged(DependencyObject d, DependencyPro
 
     private void OnTabChanged(object sender, SelectionChangedEventArgs e)
     {
-        TabControl tabControl = (TabControl)sender;
+        var tabControl = (TabControl)sender;
 
         if (e.AddedItems.Count > 0)
         {
@@ -99,7 +99,7 @@ private void AddPaddingToScrollableContentIfWiderThanViewPort()
 
         if (ScrollableContent.ActualWidth > TabControl.ActualWidth)
         {
-            double offset = TabAssist.GetTabScrollOffset(TabControl);
+            double offset = TabAssist.GetHeaderPadding(TabControl);
             ScrollableContent.Margin = new(offset, 0, offset, 0);
         }
         else

src/MaterialDesignThemes.Wpf/Internal/PaddedBringIntoViewStackPanel.cs

@@ -15,14 +15,14 @@ public TabScrollDirection ScrollDirection
         DependencyProperty.Register(nameof(ScrollDirection), typeof(TabScrollDirection),
             typeof(PaddedBringIntoViewStackPanel), new PropertyMetadata(TabScrollDirection.Unknown));
 
-    public double TabScrollOffset
+    public double HeaderPadding
     {
-        get => (double)GetValue(TabScrollOffsetProperty);
-        set => SetValue(TabScrollOffsetProperty, value);
+        get => (double)GetValue(HeaderPaddingProperty);
+        set => SetValue(HeaderPaddingProperty, value);
     }
 
-    public static readonly DependencyProperty TabScrollOffsetProperty =
-        DependencyProperty.Register(nameof(TabScrollOffset),
+    public static readonly DependencyProperty HeaderPaddingProperty =
+        DependencyProperty.Register(nameof(HeaderPadding),
             typeof(double), typeof(PaddedBringIntoViewStackPanel), new PropertyMetadata(0d));
 
     public PaddedBringIntoViewStackPanel()
@@ -36,8 +36,8 @@ private void OnRequestBringIntoView(object sender, RoutedEventArgs e)
 
             // TODO: Consider making the "ScrollDirection" a destructive read (i.e. reset the value once it is read) to avoid leaving a Backward/Forward value that may be misinterpreted at a later stage.
             double offset = ScrollDirection switch {
-                TabScrollDirection.Backward => -TabScrollOffset,
-                TabScrollDirection.Forward => TabScrollOffset,
+                TabScrollDirection.Backward => -HeaderPadding,
+                TabScrollDirection.Forward => HeaderPadding,
                 _ => 0
             };
             var point = child.TranslatePoint(new Point(), this);

src/MaterialDesignThemes.Wpf/TabAssist.cs

@@ -70,14 +70,14 @@ public static void SetHeaderBehavior(DependencyObject obj, TabControlHeaderBehav
         DependencyProperty.RegisterAttached("HeaderBehavior", typeof(TabControlHeaderBehavior), typeof(TabAssist),
             new PropertyMetadata(TabControlHeaderBehavior.Scrolling));
 
-    public static double GetTabScrollOffset(DependencyObject obj)
-        => (double)obj.GetValue(TabScrollOffsetProperty);
+    public static double GetHeaderPadding(DependencyObject obj)
+        => (double)obj.GetValue(HeaderPaddingProperty);
 
-    public static void SetTabScrollOffset(DependencyObject obj, double value)
-        => obj.SetValue(TabScrollOffsetProperty, value);
+    public static void SetHeaderPadding(DependencyObject obj, double value)
+        => obj.SetValue(HeaderPaddingProperty, value);
 
-    public static readonly DependencyProperty TabScrollOffsetProperty =
-        DependencyProperty.RegisterAttached("TabScrollOffset", typeof(double),
+    public static readonly DependencyProperty HeaderPaddingProperty =
+        DependencyProperty.RegisterAttached("HeaderPadding", typeof(double),
             typeof(TabAssist), new PropertyMetadata(0d));
 
     public static TimeSpan GetTabScrollDuration(DependencyObject obj)

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TabControl.xaml

@@ -44,7 +44,7 @@
           </b:Interaction.Behaviors>
           <internal:PaddedBringIntoViewStackPanel x:Name="ScrollableContent"
                                                   ScrollDirection="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(behaviorsInternal:TabControlHeaderScrollBehavior.ScrollDirection)}"
-                                                  TabScrollOffset="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(wpf:TabAssist.TabScrollOffset)}">
+                                                  HeaderPadding="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(wpf:TabAssist.HeaderPadding)}">
             <UniformGrid x:Name="CenteredHeaderPanel"
                                      HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"
                                      Margin="{Binding Path=(wpf:TabAssist.HeaderPanelMargin), RelativeSource={RelativeSource TemplatedParent}}"
@@ -236,7 +236,7 @@
     <Setter Property="wpf:RippleAssist.Feedback" Value="{DynamicResource MaterialDesign.Brush.Button.Ripple}" />
     <Setter Property="wpf:TabAssist.HasUniformTabWidth" Value="False" />
     <!-- MD spec says 52 DP, but that seems a little excessive in practice -->
-    <Setter Property="wpf:TabAssist.TabScrollOffset" Value="40" />
+    <Setter Property="wpf:TabAssist.HeaderPadding" Value="40" />
     <Setter Property="wpf:TabAssist.TabScrollDuration" Value="0:0:0.250" />
 
     <Style.Triggers>