Skip to content

Conversation

@jshiwamV
Copy link
Collaborator

@jshiwamV jshiwamV commented Jan 5, 2026

No description provided.

Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good quick fix, but in a follow up PR we should probably stop overriding these by default. I think these existed before we added defaults to the helm values, and we should just use those if the user hasn't overridden them.

variable "memory_request" {
description = "Memory request for environmentd"
type = string
default = "1Gi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be bumped, ideally to 1Mi less than the memory limit (4095Mi).

@jshiwamV
Copy link
Collaborator Author

jshiwamV commented Jan 7, 2026

This is a good quick fix, but in a follow up PR we should probably stop overriding these by default. I think these existed before we added defaults to the helm values, and we should just use those if the user hasn't overridden them.

https://github.com/MaterializeInc/materialize-terraform-self-managed/blob/main/aws/modules/operator/main.tf#L46 Currently we override the defaults in materialize helm values from each of operator module.I will remove the envd config from instance and put it in operator. We need to override the resource request and limit from materialize cr, since we use the values from operator resource and request as defaults.

@jshiwamV jshiwamV added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 1eebd65 Jan 7, 2026
5 checks passed
@jshiwamV jshiwamV deleted the envd-mem-limit branch January 7, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants