Set replication factor to 0 for mz_probe and mz_system by default in self managed

Author: SangJunBak

misc/helm-charts/operator/README.md

@@ -125,6 +125,8 @@ The following table lists the configurable parameters of the Materialize operato
 | `operator.cloudProvider.providers.gcp` | GCP Configuration (placeholder for future use) | ``{"enabled":false}`` |
 | `operator.cloudProvider.region` | Common cloud provider settings | ``"kind"`` |
 | `operator.cloudProvider.type` | Specifies cloud provider. Valid values are 'aws', 'gcp', 'azure' , 'generic', or 'local' | ``"local"`` |
+| `operator.clusters.defaultReplicationFactor.probe` |  | ``0`` |
+| `operator.clusters.defaultReplicationFactor.system` |  | ``0`` |
 | `operator.clusters.defaultSizes.analytics` |  | ``"25cc"`` |
 | `operator.clusters.defaultSizes.catalogServer` |  | ``"50cc"`` |
 | `operator.clusters.defaultSizes.default` |  | ``"25cc"`` |

misc/helm-charts/operator/templates/deployment.yaml

@@ -103,6 +103,12 @@ spec:
         {{ if .Values.operator.clusters.defaultSizes.analytics }}
         - "--bootstrap-builtin-analytics-cluster-replica-size={{ .Values.operator.clusters.defaultSizes.analytics }}"
         {{- end }}
+        {{ if .Values.operator.clusters.defaultReplicationFactor.system }}
+        - "--bootstrap-builtin-system-cluster-replication-factor={{ .Values.operator.clusters.defaultReplicationFactor.system }}"
+        {{- end }}
+        {{ if .Values.operator.clusters.defaultReplicationFactor.probe }}
+        - "--bootstrap-builtin-probe-cluster-replication-factor={{ .Values.operator.clusters.defaultReplicationFactor.probe }}"
+        {{- end }}
         {{- end }}
         - "--image-pull-policy={{ kebabcase .Values.operator.image.pullPolicy }}"
         {{- range $key, $value := .Values.environmentd.nodeSelector }}

misc/helm-charts/operator/values.yaml

@@ -175,6 +175,9 @@ operator:
       support: 25cc
       catalogServer: 50cc
       analytics: 25cc
+    defaultReplicationFactor:
+      system: 0
+      probe: 0
 
   # Node selector to use for the operator pod
   nodeSelector: {}

src/environmentd/tests/bootstrap_builtin_clusters.rs

@@ -22,12 +22,11 @@ fn test_zero_replication_factor_no_replicas() {
     let system_cluster = client
         .query_one(
             r#"
-    SELECT c.id, c.name, c.replication_factor::integer, COUNT(cr.id)::integer as replica_count 
+    SELECT c.id, c.name, c.replication_factor::integer, COUNT(cr.id)::integer as replica_count
     FROM mz_clusters c
     LEFT JOIN mz_cluster_replicas cr ON c.id = cr.cluster_id
     WHERE c.name = 'mz_system'
-    GROUP BY c.id, c.name, c.replication_factor
-    "#,
+    GROUP BY c.id, c.name, c.replication_factor"#,
             &[],
         )
         .unwrap();

src/orchestratord/src/controller/materialize.rs

@@ -105,9 +105,9 @@ pub struct MaterializeControllerArgs {
     #[clap(long)]
     bootstrap_builtin_support_cluster_replica_size: Option<String>,
     #[clap(long)]
-    bootstrap_builtin_catalog_server_cluster_replica_size: Option<String>,
+    bootstrap_builtin_system_cluster_replication_factor: Option<u32>,
     #[clap(long)]
-    bootstrap_builtin_analytics_cluster_replica_size: Option<String>,
+    bootstrap_builtin_probe_cluster_replication_factor: Option<u32>,
 
     #[clap(
         long,

src/orchestratord/src/controller/materialize/environmentd.rs

@@ -831,15 +831,15 @@ fn create_environmentd_statefulset_object(
                 .as_ref()
                 .map(|size| format!("--bootstrap-builtin-support-cluster-replica-size={size}")),
             config
-                .bootstrap_builtin_catalog_server_cluster_replica_size
+                .bootstrap_builtin_system_cluster_replication_factor
                 .as_ref()
-                .map(|size| {
-                    format!("--bootstrap-builtin-catalog-server-cluster-replica-size={size}")
+                .map(|replication_factor| {
+                    format!("--bootstrap-builtin-system-cluster-replication-factor={replication_factor}")
                 }),
             config
-                .bootstrap_builtin_analytics_cluster_replica_size
+                .bootstrap_builtin_probe_cluster_replication_factor
                 .as_ref()
-                .map(|size| format!("--bootstrap-builtin-analytics-cluster-replica-size={size}")),
+                .map(|replication_factor| format!("--bootstrap-builtin-probe-cluster-replication-factor={replication_factor}")),
         ]
         .into_iter()
         .flatten(),