-
Notifications
You must be signed in to change notification settings - Fork 487
Update to recent Timely and Differential #22384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e86eacd to
1fb54fd
Compare
MitigationsCompleting required mitigations increases Resilience Coverage.
Risk Summary:The pull request has a high risk score of 80, driven by predictors such as "Sum Bug Reports Of Files" and "Delta of Executable Lines." Historically, PRs with these predictors are 114% more likely to cause a bug than the repository baseline. Although the repo's predicted bug trend is decreasing, the presence of 4 file hotspots suggests elevated caution. Note: The risk score is not based on semantic analysis but on historical predictors of bug occurrence in the repository. The attributes above were deemed the strongest predictors based on that history. Predictors and the score may change as the PR evolves in code, time, and review activity. Bug Hotspots:
|
| for monoid in accum.iter() { | ||
| datums_local.extend(monoid.finalize().iter()); | ||
| } | ||
| .mz_arrange::<RowBatcher<_, _>, RowBuilder<_, _>, RowSpine<_, Vec<ReductionMonoid>>>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around here is where I thought "we have a lot of noise related to these types; would it help to have mz_arrange flavors absorb that complexity?". I don't know if/that it would, but there is an upfront tax to figuring out what to call (perhaps: great, don't add arrangement building operators folks. :D).
frankmcsherry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through everything, and superficially it checks out. I saw one case of a potential bug, though .. once I saw it I realized that there could be other moments like it.
1fb54fd to
79cbed9
Compare
d7b600a to
dbbd0b2
Compare
Signed-off-by: Moritz Hoffmann <[email protected]>
dbbd0b2 to
af7952d
Compare
Update Timely and Differential dependencies.
Most of the changes come from TimelyDataflow/differential-dataflow#544.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.