Bump clap v4#30919
Merged
alex-hunt-materialize merged 8 commits intoMaterializeInc:mainfrom Jan 2, 2025
Merged
Conversation
alex-hunt-materialize
force-pushed
the
bump_clap_v4
branch
4 times, most recently
from
fd07eb3 to
249d27c
Compare
alex-hunt-materialize
force-pushed
the
bump_clap_v4
branch
from
249d27c to
f95dd0d
Compare
alex-hunt-materialize
requested review from
a team,
ParkMyCar and
benesch
as code owners
def-
approved these changes
Jan 2, 2025
Contributor
|
Thanks for triggering nightly and making sure it's green! https://buildkite.com/materialize/nightly/builds/10765 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump clap to v4.5.23.
Also bumps criterion, to remove clap v3.
Motivation
Clap v3 has been out of date for years at this point, and we've been running yanked versions of it for a long time now.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.