bazel: make build fully hermetic #31006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
force-pushed
the
bazel/rocksdb-bindgen
branch
from
8700093 to
1ee42f1
Compare
* upgrades to clang 18.1.8-5 * upgrades to newer version of toolchains_llvm * adds rust_bindgen toolchains with new libclang package from our toolchains repo * refactors the rocksdb build to be hermetic
ParkMyCar
force-pushed
the
bazel/rocksdb-bindgen
branch
from
1ee42f1 to
641ce0e
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our Bazel build fully hermetic, mainly by refactoring how we built the
librocksdb-syscrate. Previously we had to rely on some hacks becauselibrocksdb-sysuses bindgen which was tricky to get working.Specifically the changes this PR makes are:
clang 18.1.8-5toolchains_llvmthat includes an upstream fixrust_bindgentoolchains with newlibclangpackage from our toolchains repoMotivation
Improves the quality of our build, allows us to move to a "minimum" CI builder image for faster build times
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.