Skip to content

storage: make sure the health capability is dropped #31038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkosh44 merged 1 commit into from
Jan 14, 2025
Merged

storage: make sure the health capability is dropped #31038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/storage/src/source/source_reader_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,11 +368,17 @@ where
.set(mz_persist_client::metrics::encode_ts_metric(&resume_upper));

builder.build(move |mut caps| {
let health_cap = caps.remove(1);
move |_frontiers| {
let mut health_cap = Some(caps.remove(1));
move |frontiers| {
let mut statuses_by_idx = BTreeMap::new();
let mut health_output = health_output.activate();

if frontiers.iter().all(|f| f.is_empty()) {
health_cap = None;
return;
}
let health_cap = health_cap.as_mut().unwrap();

for (id, input, output) in export_handles.iter_mut() {
while let Some((cap, data)) = input.next() {
for (message, _, _) in data.iter() {
Expand Down
Loading