Skip to content

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Jan 29, 2025

To pull in rust-lang/cmake-rs#229, which caused a major regression in Mz build times.

Motivation

  • This PR updates a dependency.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

To pull in rust-lang/cmake-rs#229, which caused
a major regression in Mz build times.
@teskje teskje requested a review from benesch January 29, 2025 14:37
@teskje teskje enabled auto-merge January 29, 2025 15:07
@teskje teskje merged commit 2b42df6 into MaterializeInc:main Jan 29, 2025
79 checks passed
@teskje teskje deleted the update-cmake branch January 29, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants