Combined logging dataflows #31229
Merged
Combined logging dataflows #31229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
watchdog_dataflow
branch
from
b1a8723 to
65e5dc1
Compare
5 tasks
antiguru
force-pushed
the
watchdog_dataflow
branch
from
65e5dc1 to
6ae9272
Compare
teskje
reviewed
Feb 19, 2025
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
Looks good, my comments are mostly about removing/simplifying stuff. There is one about not naming the logging regions Dataflow: * that I think is important though.
antiguru
force-pushed
the
watchdog_dataflow
branch
3 times, most recently
from
39a02cb to
da857ac
Compare
teskje
approved these changes
Feb 27, 2025
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
LGTM once CI agrees. Might be a good idea to run the Nightlies as well.
Pass compute events through a stream instead of injecting them into the compute event log. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
watchdog_dataflow
branch
from
da857ac to
cacf32e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine all logging dataflows into a single dataflow.
This allows easier sharing between the dataflows as events can be send through streams, instead of injecting them into the log events for later processing. The change looks substantial, but shouldn't alter behavior other than that injected commands pass through actual streams instead of injecting them into the logging dataflows.
This has some benefits: The injected commands are consistent, i.e., they arrive at the expected time, and this change enables us to share information across logging dataflows more easily, for example to do analysis such as #31246.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.