Skip to content

Fix a minor EXPLAIN bug around count(*)#31402

Merged
ggevay merged 2 commits intoMaterializeInc:mainfrom
ggevay:count-star
Feb 10, 2025
Merged

Fix a minor EXPLAIN bug around count(*)#31402
ggevay merged 2 commits intoMaterializeInc:mainfrom
ggevay:count-star

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Feb 7, 2025

See https://github.com/MaterializeInc/database-issues/issues/8831#issuecomment-2643526472

The first commit is just a 1-liner fix for the bug (and adding tests), while the second commit is a bit of refactoring to simplify some related code.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay requested review from a team as code owners February 7, 2025 17:36
@ggevay ggevay requested a review from ParkMyCar February 7, 2025 17:36
Copy link
Contributor

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks Gabor!

@ggevay ggevay added the A-CLUSTER Topics related to the CLUSTER layer label Feb 10, 2025
@ggevay ggevay merged commit d735612 into MaterializeInc:main Feb 10, 2025
81 checks passed
@ggevay ggevay mentioned this pull request Feb 26, 2025
5 tasks
@def- def- added the self-managed-backport-v25.1 Needs to be backported into the v25.1 self-managed release label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLUSTER Topics related to the CLUSTER layer self-managed-backport-v25.1-done self-managed-backport-v25.1 Needs to be backported into the v25.1 self-managed release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants