Skip to content

Tweak aoc slts to use more EXPLAIN options#31471

Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:aoc-slt-tweak
Feb 12, 2025
Merged

Tweak aoc slts to use more EXPLAIN options#31471
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:aoc-slt-tweak

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Feb 12, 2025

Adds more options to the EXPLAINs in the Advent of Code slts.

Motivation

My main motivation for this is that I'd like to see the details of join plan changes in #31281

Also, it's better to be uniform across our slts, and tpch as well as ldbc slts already use these options that I'm adding in this PR for aoc.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay requested a review from mgree February 12, 2025 18:45
@ggevay ggevay added the T-testing Theme: tests or test infrastructure label Feb 12, 2025
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggevay ggevay enabled auto-merge February 12, 2025 18:57
@ggevay ggevay merged commit 97fbe33 into MaterializeInc:main Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-testing Theme: tests or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants