Skip to content

explain: Switch default to global plan instead of physical plan#31482

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-physical-plan
Feb 13, 2025
Merged

explain: Switch default to global plan instead of physical plan#31482
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-physical-plan

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 13, 2025

Was forgotten in #31185

3c1c409 changes the default for a bare EXPLAIN to use EXPLAIN PHYSICAL PLAN. But I only changed the default in order to catch every bare EXPLAIN, and I change the default back in c97eb41.

@mgree This is a good argument for at least having one test remaining that has a bare EXPLAIN I guess ;)

Noticed by @ggevay in https://materializeinc.slack.com/archives/C08ACQNGSQK/p1739461427061339

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Was forgotten in MaterializeInc#31185

> 3c1c409 changes the default for a bare EXPLAIN to use EXPLAIN PHYSICAL PLAN. But I only changed the default in order to catch every bare EXPLAIN, and I change the default back in c97eb41.
@def- def- requested review from ggevay and mgree February 13, 2025 16:46
@def- def- requested a review from a team as a code owner February 13, 2025 16:46
@def- def- requested a review from aljoscha February 13, 2025 16:46
@def- def- enabled auto-merge February 13, 2025 16:47
@ggevay ggevay added the release-blocker Critical issue that should block *any* release if not fixed label Feb 13, 2025
@def- def- merged commit ad8051f into MaterializeInc:main Feb 13, 2025
82 of 83 checks passed
@def- def- deleted the pr-physical-plan branch February 13, 2025 17:36
ggevay added a commit to ggevay/materialize that referenced this pull request Feb 24, 2025
@ggevay ggevay mentioned this pull request Feb 24, 2025
5 tasks
def- pushed a commit to def-/materialize that referenced this pull request Feb 27, 2025
def- pushed a commit to def-/materialize that referenced this pull request Feb 27, 2025
def- pushed a commit to def-/materialize that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker Critical issue that should block *any* release if not fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants