explain: Switch default to global plan instead of physical plan#31482
Merged
def- merged 1 commit intoMaterializeInc:mainfrom Feb 13, 2025
Merged
explain: Switch default to global plan instead of physical plan#31482def- merged 1 commit intoMaterializeInc:mainfrom
def- merged 1 commit intoMaterializeInc:mainfrom
Conversation
Was forgotten in MaterializeInc#31185 > 3c1c409 changes the default for a bare EXPLAIN to use EXPLAIN PHYSICAL PLAN. But I only changed the default in order to catch every bare EXPLAIN, and I change the default back in c97eb41.
ggevay
approved these changes
Feb 13, 2025
ggevay
added a commit
to ggevay/materialize
that referenced
this pull request
Feb 24, 2025
To prevent stuff like MaterializeInc#31482
5 tasks
def-
pushed a commit
to def-/materialize
that referenced
this pull request
Feb 27, 2025
To prevent stuff like MaterializeInc#31482
def-
pushed a commit
to def-/materialize
that referenced
this pull request
Feb 27, 2025
To prevent stuff like MaterializeInc#31482
def-
pushed a commit
to def-/materialize
that referenced
this pull request
Feb 27, 2025
To prevent stuff like MaterializeInc#31482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was forgotten in #31185
@mgree This is a good argument for at least having one test remaining that has a bare
EXPLAINI guess ;)Noticed by @ggevay in https://materializeinc.slack.com/archives/C08ACQNGSQK/p1739461427061339
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.