Rework mz_dataflow_operator_reachability_per_worker join condition to be more clearly an equivalence#31860
Merged
frankmcsherry merged 1 commit intoMaterializeInc:mainfrom Mar 11, 2025
Conversation
ParkMyCar
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our built in view for
mz_dataflow_operator_reachability_per_workerhad a join condition in aCASEstatement. By pulling the equivalence out of the case statement, and making it equate a value that is aCASEstatement, the join planner can recognize it as an equijoin.As a result, queries to
mz_dataflow_operator_reachability_per_workerand derived views take substantially less time (from minutes to seconds).Issue https://github.com/MaterializeInc/database-issues/issues/9055 describes automating this transformation.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.