Implement SHOW REDACTED CREATE ...#31887
Merged
ggevay merged 3 commits intoMaterializeInc:mainfrom Mar 17, 2025
Merged
Conversation
ggevay
force-pushed
the
show-redacted-create
branch
from
b41bff5 to
3f783bc
Compare
ggevay
added
the
self-managed-backport-v25.1
Contributor
Author
|
Nightly: https://buildkite.com/materialize/nightly/builds/11468
|
ParkMyCar
approved these changes
Mar 17, 2025
Contributor
ParkMyCar
left a comment
ParkMyCar
left a comment
There was a problem hiding this comment.
See one comment in the parser, but otherwise LGTM!
src/sql-parser/src/parser.rs
Outdated
Comment on lines
7723
to
7731
| let redacted = self.parse_keyword(REDACTED); | ||
| if self.parse_one_of_keywords(&[COLUMNS, FIELDS]).is_some() { | ||
| if redacted { | ||
| return parser_err!( | ||
| self, | ||
| self.peek_prev_pos(), | ||
| "SHOW REDACTED with COLUMNS or FIELD is not supported" | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Instead of using a bunch of if-statements, what if we did something like:
let redacted = self.parse_keyword(REDACTED);
if !self.peek_keyword(CREATE) {
// ...return an error
}
Contributor
Author
There was a problem hiding this comment.
Good idea, thank you!
ggevay
force-pushed
the
show-redacted-create
branch
from
3f783bc to
ceb8012
Compare
Contributor
Author
|
Thanks for the review! |
kay-kim
reviewed
Mar 17, 2025
|
|
||
| ```sql | ||
| SHOW CREATE CONNECTION <connection_name> | ||
| SHOW [REDACTED] CREATE CONNECTION <connection_name> |
Contributor
There was a problem hiding this comment.
Should we add a blurb on what [REDACTED] does?
We can single source that statement.
Contributor
There was a problem hiding this comment.
Added a patch with the description of the REDACTED option. Feel free to update the description in the show_create_redacted_option.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add redacted counterparts to various
SHOW CREATE ...statements. We need this for redaction in the self-managed debug tool (throughmzexplore).The first commit just tweaks some comments, while the second commit is the actual thing.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.