Implement regexp_matches function#31935
Merged
DAlperin merged 18 commits intoMaterializeInc:mainfrom Mar 20, 2025
Merged
Conversation
DAlperin
requested review from
ParkMyCar and
aljoscha
and removed request for
a team and
aljoscha
antiguru
reviewed
Mar 18, 2025
antiguru
reviewed
Mar 19, 2025
src/expr/src/relation/func.rs
Outdated
Comment on lines
3153
to
3154
| let mut row = Row::default(); | ||
| let mut packer = row.packer(); |
Member
There was a problem hiding this comment.
Here would be a good place to use SharedRow, to avoid reallocations in try_push_array.
Member
Author
There was a problem hiding this comment.
Can you check if I'm holding SharedRow correctly?
Contributor
There was a problem hiding this comment.
@antiguru I might be missing an allocation somewhere, but how does SharedRow help? We need to return an iterator of owned Rows so allocating new Rows seems unavoidable?
ParkMyCar
approved these changes
Mar 19, 2025
Contributor
ParkMyCar
left a comment
ParkMyCar
left a comment
There was a problem hiding this comment.
Approved! But please add more test cases before merging
| query error invalid regular expression flag: x | ||
| SELECT regexp_replace(s, regex, replacement, 'igx') FROM e; | ||
|
|
||
| # regexp_matches |
Contributor
There was a problem hiding this comment.
Can you add more test cases? For example:
- Assert the correct error response when the second (or third) argument(s) are not string literals
- What happens when there are no matches on the source string?
- When the provided modifier is not one of
'g' or 'i' - Test case insensitive matching with 'i'
- Test
regexp_matcheswhen reading multiple rows from a table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/MaterializeInc/database-issues/issues/7096
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.