Skip to content

Comments

catalog: add wallclock lag rollup view#31968

Merged
teskje merged 1 commit intoMaterializeInc:mainfrom
teskje:wallclock-lag-rollup-view
Mar 20, 2025
Merged

catalog: add wallclock lag rollup view#31968
teskje merged 1 commit intoMaterializeInc:mainfrom
teskje:wallclock-lag-rollup-view

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Mar 20, 2025

This PR adds a new view, mz_internal.mz_wallclock_global_lag that shows the most recent wallclock lag values from all collections. The intention is to have something that's easier to use for people that want to inspect the current freshness of their objects and are not interested in historical values.

Motivation

  • This PR adds a feature that has not yet been specified.

Request from @sjwiesman in Slack.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje teskje requested review from a team as code owners March 20, 2025 15:38
@teskje teskje requested a review from ParkMyCar March 20, 2025 15:38
@teskje teskje force-pushed the wallclock-lag-rollup-view branch from 47b9b77 to a935954 Compare March 20, 2025 16:21
Copy link
Contributor

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to duplicate existing views a bit, but otherwise LGTM!

@teskje
Copy link
Contributor Author

teskje commented Mar 20, 2025

Yeah, it's purely a convenience view over mz_wallclock_global_lag_recent_history that we feel better about exposing to users because (a) they don't have to write the Top1 query themselves and (b) it doesn't have the extremely internal sounding name :)

This commit adds a new view, `mz_internal.mz_wallclock_global_lag` that
shows the most recent wallclock lag values from all collections. The
intention is to have something that's easier to use for people that want
to inspect the current freshness of their objects and are not interested
in historical values.
@teskje teskje force-pushed the wallclock-lag-rollup-view branch from a935954 to a35cbc4 Compare March 20, 2025 17:08
@teskje
Copy link
Contributor Author

teskje commented Mar 20, 2025

TFTR!

@teskje teskje merged commit 226a3f9 into MaterializeInc:main Mar 20, 2025
86 checks passed
@teskje teskje deleted the wallclock-lag-rollup-view branch March 20, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants