error_if_null: Lazily evaluate error#32019
Merged
antiguru merged 1 commit intoMaterializeInc:mainfrom Mar 26, 2025
Merged
Conversation
At the moment, `error_if_null` evaluates both its input, and in most cases discards the error input. This causes us to do a lot of unnecessary work in the common case. Instead, only evaluate the error expression (second input) if the first one evaluates to null. Related: MaterializeInc/database-issues#9125 Signed-off-by: Moritz Hoffmann <mh@materialize.com>
mgree
approved these changes
Mar 26, 2025
Contributor
mgree
left a comment
mgree
left a comment
There was a problem hiding this comment.
Looks good to me. It would make sense to change it to BinaryFunc in this PR, but also if it ain't broke...
Member
Author
|
Thanks for the review. I'll file an issue to change it to a binary function separately. |
Member
Author
|
Here it is: MaterializeInc/database-issues/issues/9126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
error_if_nullevaluates both its input, and in most cases discards the error input. This causes us to do a lot of unnecessary work in the common case.Instead, only evaluate the error expression (second input) if the first one evaluates to null.
Related: MaterializeInc/database-issues#9125
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.