Skip to content

[sql_server] add sql-server-cdc-old-syntax test suite #33265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2025
Merged

[sql_server] add sql-server-cdc-old-syntax test suite #33265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f6ffb3
add sql-server-cdc-old-syntax tests
ptravers Aug 14, 2025
6b17a19
fix pr feedback
ptravers Aug 14, 2025
c51c0c7
remove from nightly
ptravers Aug 14, 2025
05e2000
add new line to test files
ptravers Aug 14, 2025
fae5004
ci: increase parallelism
ptravers Aug 15, 2025
fcfd51a
fix flake by increasing timeout for long running query
ptravers Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions ci/test/pipeline.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,20 +378,38 @@ steps:
# Too slow on aarch64
queue: hetzner-x86-64-4cpu-8gb

- id: sql-server-cdc
label: "SQL Server CDC tests"
depends_on: build-x86_64
timeout_in_minutes: 30
inputs: [test/sql-server-cdc]
parallelism: 3
plugins:
- ./ci/plugins/mzcompose:
composition: sql-server-cdc
agents:
# The SQL Server Docker image isn't available on ARM.
#
# See: <https://github.com/microsoft/mssql-docker/issues/864>
queue: hetzner-x86-64-8cpu-16gb
- group: "SQL Server tests"
key: sql-server-tests
steps:
- id: sql-server-cdc
label: "SQL Server CDC tests"
depends_on: build-x86_64
timeout_in_minutes: 30
inputs: [test/sql-server-cdc]
parallelism: 3
plugins:
- ./ci/plugins/mzcompose:
composition: sql-server-cdc
agents:
# The SQL Server Docker image isn't available on ARM.
#
# See: <https://github.com/microsoft/mssql-docker/issues/864>
queue: hetzner-x86-64-8cpu-16gb

- id: sql-server-cdc-old-syntax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this to nightly once we have the same coverage in the sql-server-cdc (new syntax) tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. makes sense.

label: "SQL Server CDC old syntax tests"
depends_on: build-x86_64
timeout_in_minutes: 30
inputs: [test/sql-server-cdc-old-syntax]
parallelism: 6
plugins:
- ./ci/plugins/mzcompose:
composition: sql-server-cdc-old-syntax
agents:
# The SQL Server Docker image isn't available on ARM.
#
# See: <https://github.com/microsoft/mssql-docker/issues/864>
queue: hetzner-x86-64-8cpu-16gb

- group: "Connection tests"
key: connection-tests
Expand Down
1 change: 1 addition & 0 deletions misc/python/materialize/mzcompose/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def get_minimal_system_parameters(
"enable_reduce_mfp_fusion": "true",
"enable_refresh_every_mvs": "true",
"enable_cluster_schedule_refresh": "true",
"enable_sql_server_source": "true",
"enable_statement_lifecycle_logging": "true",
"enable_compute_temporal_bucketing": "true",
"enable_variadic_left_join_lowering": "true",
Expand Down
Loading