Skip to content

Allow setting service account name in Materialize CR #33288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

Allow setting service account name in Materialize CR #33288

merged 2 commits into from
Aug 13, 2025

Conversation

alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented Aug 11, 2025 •
edited
Loading

Allow setting service account name in Materialize CR.
Also makes the environmentd_iam_role_arn optional in AWS.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize force-pushed the allow_setting_service_account_name branch from dc8830f to 796ee1e Compare August 11, 2025 15:27
@alex-hunt-materialize alex-hunt-materialize force-pushed the allow_setting_service_account_name branch from bdceff8 to 6854ca4 Compare August 11, 2025 16:25
@alex-hunt-materialize alex-hunt-materialize force-pushed the allow_setting_service_account_name branch from 6854ca4 to 6916f9d Compare August 11, 2025 16:50
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review August 12, 2025 11:11
@alex-hunt-materialize alex-hunt-materialize requested a review from a team as a code owner August 12, 2025 11:11
@sjwiesman sjwiesman added the self-managed-backport-v25.2 Needs to be backported into the v25.2 self-managed release label Aug 12, 2025
@alex-hunt-materialize alex-hunt-materialize merged commit 667ebfb into MaterializeInc:main Aug 13, 2025
131 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the allow_setting_service_account_name branch August 13, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doy-materialize doy-materialize doy-materialize approved these changes

Assignees
No one assigned
Labels
self-managed-backport-v25.2-done self-managed-backport-v25.2 Needs to be backported into the v25.2 self-managed release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-hunt-materialize @doy-materialize @sjwiesman @def-