Skip to content

Fix cargo docs following new nightly version #33311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2025
Merged

Fix cargo docs following new nightly version #33311

merged 2 commits into from
Aug 15, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Aug 12, 2025 •
edited
Loading

Seen in https://buildkite.com/materialize/deploy/builds/19309#_

Follow-up to #33290

Reproducer: rustup run nightly bin/doc --document-private-items

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from teskje August 12, 2025 21:05
@def- def- requested review from a team as code owners August 12, 2025 21:05
@def- def- requested review from aljoscha and ggevay August 12, 2025 21:05
@def- def- enabled auto-merge August 13, 2025 09:15
teskje
teskje reviewed Aug 13, 2025
View reviewed changes
@def- def- requested a review from a team as a code owner August 13, 2025 14:34
@def- def- requested a review from teskje August 13, 2025 14:35
teskje
teskje reviewed Aug 14, 2025
View reviewed changes
@def- def- requested a review from teskje August 14, 2025 12:12
teskje
teskje approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@def- def- merged commit 2e9c047 into MaterializeInc:main Aug 15, 2025
132 checks passed
@def- def- deleted the pr-doc-deploy branch August 15, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teskje teskje teskje approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner automatically assigned from MaterializeInc/adapter

@ggevay ggevay Awaiting requested review from ggevay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @teskje