[sql_server] remove enabling sql server in test as defaults to enabled #33315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptravers
changed the title
ptravers
changed the title
def-
approved these changes
Aug 14, 2025
martykulma
reviewed
Aug 14, 2025
|
they might just be newer. this is an old change set. will check them. |
ptravers
commented
Aug 14, 2025
Comment on lines
35
to
36
| $ postgres-execute connection=postgres://mz_system:materialize@${testdrive.materialize-internal-sql-addr} | ||
| ALTER SYSTEM SET log_filter = 'mz_sql=debug,info'; |
There was a problem hiding this comment.
left this in but am slightly worried that we will be logging a lot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sql server is enabled by default
Tips for reviewer
small set of refactors to the sql server cdc tests following updates in: #33265
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.