catalog: use JSON for WireCompatible serialization
#33843
Draft
+83
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of moving away from protobuf in the catalog, we need to change the serialization `WireCompatible` uses to convert one type into the other. The catalog state is serialized as JSON, so we can just use JSON here as well.
Wire compatibility is a networking term and somewhat confusing in the context of a catalog. This commit renames the `WireCompatible` trait and `wire_compatible!` macro to `JsonCompatible`/`json_compatible!`. The new name also surfaces the requirement that implementing types must be JSON-serializable.
Moving the module rename into a separate commit to keep the diff clean.
teskje
force-pushed
the
json_compatible
branch
from
6f16b05 to
f2f2c99
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving away from protobuf in the catalog, we need to change the serialization
WireCompatibleuses to convert one type into the other. The catalog state is serialized as JSON, so we can just use JSON here as well.This PR also renames
WireCompatible/wire_compatibletoJsonCompatible/json_compatible, to improve clarity.Motivation
Step (1) of https://github.com/MaterializeInc/database-issues/issues/9792
Tips for reviewer
I've move the module renaming to the last commit, so the individual commit diffs are easy to review.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.