Skip to content

fix running new environmentds when --disable-license-key-checks is given #33857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
+9 −1
Merged

fix running new environmentds when --disable-license-key-checks is given #33857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/orchestratord/src/controller/materialize/environmentd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,11 +1268,19 @@ fn create_environmentd_statefulset_object(
args.push("--orchestrator-kubernetes-enable-prometheus-scrape-annotations".into());
}

// the --disable-license-key-checks environmentd flag only existed
// between these versions
if config.disable_license_key_checks {
if mz.meets_minimum_version(&V143) && !mz.meets_minimum_version(&V153) {
args.push("--disable-license-key-checks".into());
}
} else if mz.meets_minimum_version(&V140_DEV0) {
}

// as of version 0.153, the ability to disable license key checks was
// removed, so we should always set up license keys in that case
if (mz.meets_minimum_version(&V140_DEV0) && !config.disable_license_key_checks)
|| mz.meets_minimum_version(&V153)
{
volume_mounts.push(VolumeMount {
name: "license-key".to_string(),
mount_path: "/license_key".to_string(),
Expand Down